well if ur into photography or video go for iphone x. but in terms of battery life, internal memory, bigger screen size adn many other aspects including great camera quality the s10 could be ur choice. overall i would prefer the samsung 10 plus.